Review Request 117490: Improve FindEGL.cmake

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117490/#review55748
-----------------------------------------------------------


Looks good to me, but I'd rather have someone else look at it.

- Kevin Ottens


On April 11, 2014, 8:21 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117490/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 8:21 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Improve FindEGL.cmake
> 
> - Add version handling
> - Improve the docs
> - mark cache variables as advanced
> - make the pkg-config call actually work
> 
> 
> Diffs
> -----
> 
>   find-modules/FindEGL.cmake 765b6692a23486afa36c9c92adad7cb294756a30 
> 
> Diff: https://git.reviewboard.kde.org/r/117490/diff/
> 
> 
> Testing
> -------
> 
> Configured and built KWin successfully.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140414/aa81132d/attachment.html>