Review Request 117154: Simplify the plugin lookup code

Kevin Ottens ervin at kde.org
Mon Apr 14 14:49:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117154/#review55739
-----------------------------------------------------------

Ship it!


2 weeks without reaction so I'll give it a shot. Not that I'm a windows expert, but the change looks fine to me.

- Kevin Ottens


On March 29, 2014, 11:01 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117154/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 11:01 a.m.)
> 
> 
> Review request for KDE Frameworks, kdewin, Alexander Richardson, and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Simplify the plugin lookup code
> 
> 
> Diffs
> -----
> 
>   src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b 
> 
> Diff: https://git.reviewboard.kde.org/r/117154/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass and generally seems to work on my Linux machine.  Windows stuff completely untested.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140414/da7544b2/attachment.html>


More information about the Kde-frameworks-devel mailing list