Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

[Martin Klapetek]

> On April 14, 2014, 2:53 p.m., Aleix Pol Gonzalez wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 168
> > <https://git.reviewboard.kde.org/r/117435/diff/2/?file=263450#file263450line168>
> >
> >     Don't you need to set a title or anything like that? Maybe we can set the same title for either code path?

The title is handled in KDirSelectDialog as well as all other init code (I wanted the changes as little disruptive as possible); it says "Select folder" which I think works for both saving and opening, so imho no need for changing that.


> On April 14, 2014, 2:53 p.m., Aleix Pol Gonzalez wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 146
> > <https://git.reviewboard.kde.org/r/117435/diff/2/?file=263450#file263450line146>
> >
> >     ?

Ah yeah, that's from the first iteration of the patch and can be just reverted.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117435/#review55716
-----------------------------------------------------------


On April 8, 2014, 6:14 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117435/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 6:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This imports KDirSelectDialog from kde4support into frameworksintegration (+ KFileTreeView) and uses the dir select dialog in case the user wants to select a directory.
> 
> To not disturb the current code too much, I've created a new class KDEPlatformFileDialogBase, made KDEPlatformFileDialog derive from that as well as KDirSelectDialog, and then KDEPlatformFileDialogHelper stores the KDEPlatformFileDialogBase pointer, which is either the file selector or dialog selector, but with the same API. The API is just added to KDirSelectDialog and it calls its own functions internally.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 8611b29 
>   src/platformtheme/CMakeLists.txt e9a2454 
>   src/platformtheme/kdeplatformfiledialogbase.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformfiledialogbase_p.h PRE-CREATION 
>   src/platformtheme/kdeplatformfiledialoghelper.h 4621071 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp c834703 
>   src/platformtheme/kdirselectdialog.cpp PRE-CREATION 
>   src/platformtheme/kdirselectdialog_p.h PRE-CREATION 
>   src/platformtheme/kfiletreeview.cpp PRE-CREATION 
>   src/platformtheme/kfiletreeview_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117435/diff/
> 
> 
> Testing
> -------
> 
> The testing app in tests/ works exactly as expected; all autotests pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140414/e921c708/attachment.html>