Review Request 117531: Remove Messages.sh in kcrash, it has no GUI strings

[Albert Astals Cid]

> On April 13, 2014, 12:37 p.m., Luigi Toscano wrote:
> > I don't find the discussion now, but I think that it was decided to keep Messages.sh to not forget it later if the framework introduces some i18n/tr calls. Maybe it could be possible to tune the scripts to be smart and not generate the template if no messages are found? Albert, Aurelien (or anyone else) do you remember what was decided?
> 
> Burkhard Lück wrote:
>     I doubt that such a rule is very rea?iable, e. g. drkonki lost 200 msgs from extraction due to code file moves a few days ago. Having a Messages.sh did not prevent that.

Yes, we decided it may be a good idea to have the Messages.sh in there just in case some strings would added and noone noticed. Of course having a Message.sh won't prevent major fuckups if people don't care, but it should help a bit. Now with "pure" xgettext a Messsages.sh won't create a .po unless there's one string or more. I guess it's the .ts to .po conversion that ends up creating an empty .po file

Personally I would prefer keeping the thing, what is the problem of having it?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117531/#review55585
-----------------------------------------------------------


On April 13, 2014, 9:15 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117531/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 9:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> -------
> 
> Messages.sh in kcrash generates an empty catalog, because this module does not have GUI strings/tr() calls.
> 
> 
> Diffs
> -----
> 
>   src/Messages.sh 501efe4 
> 
> Diff: https://git.reviewboard.kde.org/r/117531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140413/f229577e/attachment-0001.html>