Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117475/#review55539
-----------------------------------------------------------


We might not install such desktop files anymore, but I don't understand "the code path this tested no longer exists"?

Recently clarifications to the desktop entry spec define more precisely what a "desktop file id" is, and it can look like vendor-filename.desktop if the file is vendor/filename.desktop on disk, so I'd rather we keep making sure this works.

- David Faure


On April 12, 2014, 6:39 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117475/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 6:39 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> kmimeassociationstest: remove kde4- prefix from desktop file names
> 
> The code path this tested no longer exists.
> 
> 
> Diffs
> -----
> 
>   autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 
> 
> Diff: https://git.reviewboard.kde.org/r/117475/diff/
> 
> 
> Testing
> -------
> 
> Test still passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140412/6b0a0505/attachment.html>