Review Request 117511: Add class for finding the kde4 config and apps home dirs.
Kevin Krammer
krammer at kde.org
Sat Apr 12 11:12:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117511/#review55504
-----------------------------------------------------------
I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant for KDE applications porting, right?
IMHO this would fit best in an explicit porting framework
src/lib/util/kdelibs4migration.cpp
<https://git.reviewboard.kde.org/r/117511/#comment38618>
initialize d to nullptr?
- Kevin Krammer
On April 12, 2014, 11:01 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117511/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 11:01 a.m.)
>
>
> Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Add class for finding the kde4 config and apps home dirs.
>
> To help applications migrating to the kf5/qt5 directories.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 7ab7bc43be1434ae93f7c77af90e41bbde5168ac
> autotests/kdelibs4migrationtest.cpp PRE-CREATION
> src/lib/CMakeLists.txt 1d17874f0da428bd34ea85ee98683f6fef620c81
> src/lib/util/kdelibs4migration.h PRE-CREATION
> src/lib/util/kdelibs4migration.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117511/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140412/86017b0f/attachment.html>
More information about the Kde-frameworks-devel
mailing list