Review Request 117454: Implement KUser::faceIconPath for Windows XP

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117454/#review55319
-----------------------------------------------------------

Ship it!


Looks good, but hopefully we can drop XP support soon

- Alexander Richardson


On April 9, 2014, 7:06 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117454/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 7:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> The undocuented API we're using has a different ordinal and parameters on Windows XP vs Vista/7.
> 
> I refactored the code to use a template and structs encapsulating the differences, as otherwise the code became too redundant.
> 
> Feedback welcome on identifier names, that's a known hard problem :)
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kuser_win.cpp aa48c04 
> 
> Diff: https://git.reviewboard.kde.org/r/117454/diff/
> 
> 
> Testing
> -------
> 
> Ran faceicontest on Windows 7 and on XP.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140410/a0eeca60/attachment.html>