Review Request 117457: kio-extras: minor dependencies cleanup

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117457/#review55313
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/117457/#comment38520>

    You shouldn't need Core and Gui, they're both pulled by Widgets.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/117457/#comment38521>

    I would prefer using find_package(KF5) for all of them



thumbnail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117457/#comment38522>

    Good catch!
    Now that you're here, remove the commented target_link_libraries, it's never going to be useful


- Aleix Pol Gonzalez


On April 9, 2014, 6:35 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117457/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 6:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> KWin and libksysguard are not required. same with KDeclarative, Plasma, KWindowSystem, Qt5Quick, Qt5Script. Added frameworks in top CMakeLists where linked in subdirectories, so explicitly search for them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e67becb 
>   thumbnail/CMakeLists.txt 97fdbb0 
> 
> Diff: https://git.reviewboard.kde.org/r/117457/diff/
> 
> 
> Testing
> -------
> 
> Built successfully with CMake 3.0.0-rc3 & Frameworks HEAD.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140409/a35c3a69/attachment.html>