Review Request 117440: Make sure that common licenses are accessed throught help:/ protocol

Burkhard Lück lueck at hube-lueck.de
Wed Apr 9 09:49:06 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117440/#review55266
-----------------------------------------------------------

Ship it!


Works for me, thanks

- Burkhard Lück


On April 8, 2014, 10:02 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117440/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 10:02 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> This change removes one of the reason for keeping the "common"/ symlinks into documentation directories; translated common licenses are accessed now using the help:/ kioslave, which finds them in <lang>/common.
> Please note that help:/<common> prefix can be overridden by changing the kde.common parameter (for example, generation of documentation on the website).
> 
> 
> Diffs
> -----
> 
>   src/customization/af/entities/underArtisticLicense.docbook f19b961 
>   src/customization/af/entities/underBSDLicense.docbook 1222e95 
>   src/customization/af/entities/underFDL.docbook 6afff8b 
>   src/customization/af/entities/underGPL.docbook 6d8ef8b 
>   src/customization/af/entities/underX11License.docbook a216e53 
>   src/customization/bg/entities/underArtisticLicense.docbook fa02270 
>   src/customization/bg/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/bg/entities/underFDL.docbook 633ce72 
>   src/customization/bg/entities/underGPL.docbook a2074f3 
>   src/customization/bg/entities/underX11License.docbook 7eb81f0 
>   src/customization/ca/entities/underArtisticLicense.docbook 300167f 
>   src/customization/ca/entities/underBSDLicense.docbook 4bde1df 
>   src/customization/ca/entities/underFDL.docbook 7ab5762 
>   src/customization/ca/entities/underGPL.docbook 1bfeec7 
>   src/customization/ca/entities/underLGPL.docbook 1bf0a38 
>   src/customization/ca/entities/underX11License.docbook 4e1093e 
>   src/customization/cs/entities/underArtisticLicense.docbook fa02270 
>   src/customization/cs/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/cs/entities/underFDL.docbook 65d5936 
>   src/customization/cs/entities/underGPL.docbook 27d9047 
>   src/customization/cs/entities/underX11License.docbook 7eb81f0 
>   src/customization/da/entities/underArtisticLicense.docbook 612fb2e 
>   src/customization/da/entities/underBSDLicense.docbook 3d2630b 
>   src/customization/da/entities/underFDL.docbook 78acfee 
>   src/customization/da/entities/underGPL.docbook 97e0af6 
>   src/customization/da/entities/underLGPL.docbook 591c332 
>   src/customization/da/entities/underX11License.docbook 69bad4c 
>   src/customization/de/entities/underArtisticLicense.docbook 78d63bc 
>   src/customization/de/entities/underBSDLicense.docbook ffbdf67 
>   src/customization/de/entities/underFDL.docbook dbb7c69 
>   src/customization/de/entities/underGPL.docbook 3bc2ca2 
>   src/customization/de/entities/underLGPL.docbook 91c4ee8 
>   src/customization/de/entities/underX11License.docbook 9027b44 
>   src/customization/el/entities/underArtisticLicense.docbook fa02270 
>   src/customization/el/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/el/entities/underFDL.docbook 65d5936 
>   src/customization/el/entities/underGPL.docbook 27d9047 
>   src/customization/el/entities/underX11License.docbook 7eb81f0 
>   src/customization/en-GB/entities/underArtisticLicense.docbook fa02270 
>   src/customization/en-GB/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/en-GB/entities/underFDL.docbook 633ce72 
>   src/customization/en-GB/entities/underGPL.docbook a2074f3 
>   src/customization/en-GB/entities/underX11License.docbook 7eb81f0 
>   src/customization/en/entities/underArtisticLicense.docbook fa02270 
>   src/customization/en/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/en/entities/underFDL.docbook 633ce72 
>   src/customization/en/entities/underGPL.docbook a2074f3 
>   src/customization/en/entities/underLGPL.docbook 35f89bd 
>   src/customization/en/entities/underX11License.docbook 7eb81f0 
>   src/customization/eo/entities/underArtisticLicense.docbook b214453 
>   src/customization/eo/entities/underBSDLicense.docbook 2eea358 
>   src/customization/eo/entities/underFDL.docbook edcab1b 
>   src/customization/eo/entities/underGPL.docbook 69ccd1d 
>   src/customization/eo/entities/underX11License.docbook f1295ff 
>   src/customization/es/entities/underArtisticLicense.docbook fdb0555 
>   src/customization/es/entities/underBSDLicense.docbook 78c5742 
>   src/customization/es/entities/underFDL.docbook 18b96e2 
>   src/customization/es/entities/underGPL.docbook 2bee3b0 
>   src/customization/es/entities/underLGPL.docbook 6340667 
>   src/customization/es/entities/underX11License.docbook 5f40cc0 
>   src/customization/et/entities/underArtisticLicense.docbook a17c99d 
>   src/customization/et/entities/underBSDLicense.docbook a231ded 
>   src/customization/et/entities/underFDL.docbook 4835cfbc 
>   src/customization/et/entities/underGPL.docbook 20306e9 
>   src/customization/et/entities/underLGPL.docbook f854aeb 
>   src/customization/et/entities/underX11License.docbook 1975fd7 
>   src/customization/fi/entities/underArtisticLicense.docbook fa02270 
>   src/customization/fi/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/fi/entities/underFDL.docbook 2c280e1 
>   src/customization/fi/entities/underGPL.docbook ed52610 
>   src/customization/fi/entities/underX11License.docbook 7eb81f0 
>   src/customization/fo/entities/underArtisticLicense.docbook fa02270 
>   src/customization/fo/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/fo/entities/underFDL.docbook 633ce72 
>   src/customization/fo/entities/underGPL.docbook a2074f3 
>   src/customization/fo/entities/underX11License.docbook 7eb81f0 
>   src/customization/fr/entities/underArtisticLicense.docbook d4fe287 
>   src/customization/fr/entities/underBSDLicense.docbook 1850520 
>   src/customization/fr/entities/underFDL.docbook 0930a88 
>   src/customization/fr/entities/underGPL.docbook 2d7d981 
>   src/customization/fr/entities/underLGPL.docbook 169f26e 
>   src/customization/fr/entities/underX11License.docbook f723d72 
>   src/customization/gl/entities/underArtisticLicense.docbook f986031 
>   src/customization/gl/entities/underBSDLicense.docbook c52a652 
>   src/customization/gl/entities/underFDL.docbook ca50ca8 
>   src/customization/gl/entities/underGPL.docbook 3860c46 
>   src/customization/gl/entities/underLGPL.docbook 3b3d24a 
>   src/customization/gl/entities/underX11License.docbook bc30303 
>   src/customization/he/entities/underArtisticLicense.docbook 558e289 
>   src/customization/he/entities/underBSDLicense.docbook 4c8f45d 
>   src/customization/he/entities/underFDL.docbook 77889f9 
>   src/customization/he/entities/underGPL.docbook 52638da 
>   src/customization/he/entities/underX11License.docbook e8aa200 
>   src/customization/hu/entities/underArtisticLicense.docbook 2cebf0a 
>   src/customization/hu/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/hu/entities/underFDL.docbook 65d5936 
>   src/customization/hu/entities/underGPL.docbook 27d9047 
>   src/customization/hu/entities/underX11License.docbook 7eb81f0 
>   src/customization/id/entities/underArtisticLicense.docbook fa02270 
>   src/customization/id/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/id/entities/underFDL.docbook 633ce72 
>   src/customization/id/entities/underGPL.docbook 27d9047 
>   src/customization/id/entities/underX11License.docbook 7eb81f0 
>   src/customization/it/entities/underArtisticLicense.docbook 0663503 
>   src/customization/it/entities/underBSDLicense.docbook a2bcb21 
>   src/customization/it/entities/underFDL.docbook 076fc87 
>   src/customization/it/entities/underGPL.docbook 4cb7b76 
>   src/customization/it/entities/underLGPL.docbook bd8be20 
>   src/customization/it/entities/underX11License.docbook b9144c8 
>   src/customization/ja/entities/underArtisticLicense.docbook cd00e9a 
>   src/customization/ja/entities/underBSDLicense.docbook 587815c 
>   src/customization/ja/entities/underFDL.docbook 4d4d204 
>   src/customization/ja/entities/underGPL.docbook 7e7dbd4 
>   src/customization/ja/entities/underX11License.docbook 6de034c 
>   src/customization/kde-chunk-common.xsl 0565861 
>   src/customization/ko/entities/underArtisticLicense.docbook 53c5786 
>   src/customization/ko/entities/underBSDLicense.docbook 3f07b31 
>   src/customization/ko/entities/underFDL.docbook 645b26c 
>   src/customization/ko/entities/underGPL.docbook 6c53282 
>   src/customization/ko/entities/underLGPL.docbook 158e0de 
>   src/customization/ko/entities/underX11License.docbook 512bfcb 
>   src/customization/lt/entities/underArtisticLicense.docbook 204ed6c 
>   src/customization/lt/entities/underBSDLicense.docbook 21b3804 
>   src/customization/lt/entities/underFDL.docbook f5fe4aa 
>   src/customization/lt/entities/underGPL.docbook 7d8d99f 
>   src/customization/lt/entities/underLGPL.docbook daedcb8 
>   src/customization/lt/entities/underX11License.docbook 86ea629 
>   src/customization/nds/entities/underArtisticLicense.docbook 4185aaa 
>   src/customization/nds/entities/underBSDLicense.docbook 9e4e4b1 
>   src/customization/nds/entities/underFDL.docbook 46e9852 
>   src/customization/nds/entities/underGPL.docbook ffe4a36 
>   src/customization/nds/entities/underLGPL.docbook 71d936c 
>   src/customization/nds/entities/underX11License.docbook 2e02195 
>   src/customization/nl/entities/underArtisticLicense.docbook 54dc82f 
>   src/customization/nl/entities/underBSDLicense.docbook b3b47db 
>   src/customization/nl/entities/underFDL.docbook 69d885c 
>   src/customization/nl/entities/underGPL.docbook a8f4339 
>   src/customization/nl/entities/underLGPL.docbook 10fc77e 
>   src/customization/nl/entities/underX11License.docbook 6a71bc4 
>   src/customization/nn/entities/underArtisticLicense.docbook 81073c3 
>   src/customization/nn/entities/underBSDLicense.docbook cd64224 
>   src/customization/nn/entities/underFDL.docbook 0ed297c 
>   src/customization/nn/entities/underGPL.docbook 3a841a1 
>   src/customization/nn/entities/underX11License.docbook 4bbedd5 
>   src/customization/no/entities/underArtisticLicense.docbook fa02270 
>   src/customization/no/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/no/entities/underFDL.docbook 65d5936 
>   src/customization/no/entities/underGPL.docbook 27d9047 
>   src/customization/no/entities/underX11License.docbook 7eb81f0 
>   src/customization/pl/entities/underArtisticLicense.docbook 832a64d 
>   src/customization/pl/entities/underBSDLicense.docbook 5256c41 
>   src/customization/pl/entities/underFDL.docbook 5fec52e 
>   src/customization/pl/entities/underGPL.docbook 71cfe79 
>   src/customization/pl/entities/underLGPL.docbook 688da04 
>   src/customization/pl/entities/underX11License.docbook 45a7296 
>   src/customization/pt-BR/entities/underArtisticLicense.docbook a0a55c7 
>   src/customization/pt-BR/entities/underBSDLicense.docbook a29ddfa 
>   src/customization/pt-BR/entities/underFDL.docbook 3228ec5 
>   src/customization/pt-BR/entities/underGPL.docbook 8d98646 
>   src/customization/pt-BR/entities/underLGPL.docbook 7d314d9 
>   src/customization/pt-BR/entities/underX11License.docbook 7e87319 
>   src/customization/pt/entities/underArtisticLicense.docbook f8c2929 
>   src/customization/pt/entities/underBSDLicense.docbook e960020 
>   src/customization/pt/entities/underFDL.docbook 4527189 
>   src/customization/pt/entities/underGPL.docbook a12f134 
>   src/customization/pt/entities/underLGPL.docbook 50803a6 
>   src/customization/pt/entities/underX11License.docbook 01a68af 
>   src/customization/ro/entities/underArtisticLicense.docbook ba338c6 
>   src/customization/ro/entities/underBSDLicense.docbook 5697153 
>   src/customization/ro/entities/underFDL.docbook 44788b0 
>   src/customization/ro/entities/underGPL.docbook 60198ad 
>   src/customization/ro/entities/underLGPL.docbook 85e9319 
>   src/customization/ro/entities/underX11License.docbook bb5c79a 
>   src/customization/ru/entities/underArtisticLicense.docbook f8f1b4e 
>   src/customization/ru/entities/underBSDLicense.docbook 72c5bfb 
>   src/customization/ru/entities/underFDL.docbook 453ae9e 
>   src/customization/ru/entities/underGPL.docbook ff75e75 
>   src/customization/ru/entities/underLGPL.docbook c2b1b59 
>   src/customization/ru/entities/underX11License.docbook c213884 
>   src/customization/sk/entities/underArtisticLicense.docbook abd171c 
>   src/customization/sk/entities/underBSDLicense.docbook a71f473 
>   src/customization/sk/entities/underFDL.docbook 37e7565 
>   src/customization/sk/entities/underGPL.docbook b47a186 
>   src/customization/sk/entities/underX11License.docbook bfb74eb 
>   src/customization/sl/entities/underArtisticLicense.docbook ed006ed 
>   src/customization/sl/entities/underBSDLicense.docbook 962a17f 
>   src/customization/sl/entities/underFDL.docbook be31d7d 
>   src/customization/sl/entities/underGPL.docbook da0aa08 
>   src/customization/sl/entities/underX11License.docbook a618875 
>   src/customization/sq/entities/underArtisticLicense.docbook 0c4a7da 
>   src/customization/sq/entities/underBSDLicense.docbook 8e668b6 
>   src/customization/sq/entities/underFDL.docbook 80aa6e3 
>   src/customization/sq/entities/underGPL.docbook c6e438a 
>   src/customization/sq/entities/underLGPL.docbook fbff7e2 
>   src/customization/sq/entities/underX11License.docbook aef5aec 
>   src/customization/sr/entities/underArtisticLicense.docbook bd2d522 
>   src/customization/sr/entities/underBSDLicense.docbook 98c5791 
>   src/customization/sr/entities/underFDL.docbook c1ba7c7 
>   src/customization/sr/entities/underGPL.docbook 9c0c8fb 
>   src/customization/sr/entities/underLGPL.docbook 81d5ba5 
>   src/customization/sr/entities/underX11License.docbook 865ded0 
>   src/customization/sr at ijekavian/entities/underArtisticLicense.docbook 485d8b7 
>   src/customization/sr at ijekavian/entities/underBSDLicense.docbook 98c5791 
>   src/customization/sr at ijekavian/entities/underFDL.docbook c1ba7c7 
>   src/customization/sr at ijekavian/entities/underGPL.docbook 9c0c8fb 
>   src/customization/sr at ijekavian/entities/underLGPL.docbook 81d5ba5 
>   src/customization/sr at ijekavian/entities/underX11License.docbook 865ded0 
>   src/customization/sr at ijekavianlatin/entities/underArtisticLicense.docbook 0409234 
>   src/customization/sr at ijekavianlatin/entities/underBSDLicense.docbook c795721 
>   src/customization/sr at ijekavianlatin/entities/underFDL.docbook 874c67a 
>   src/customization/sr at ijekavianlatin/entities/underGPL.docbook 9ab11c1 
>   src/customization/sr at ijekavianlatin/entities/underLGPL.docbook f5dc4ca 
>   src/customization/sr at ijekavianlatin/entities/underX11License.docbook 9d067fd 
>   src/customization/sr at latin/entities/underArtisticLicense.docbook 63d6287 
>   src/customization/sr at latin/entities/underBSDLicense.docbook c795721 
>   src/customization/sr at latin/entities/underFDL.docbook 874c67a 
>   src/customization/sr at latin/entities/underGPL.docbook 9ab11c1 
>   src/customization/sr at latin/entities/underLGPL.docbook f5dc4ca 
>   src/customization/sr at latin/entities/underX11License.docbook 9d067fd 
>   src/customization/sv/entities/underArtisticLicense.docbook c43cad2 
>   src/customization/sv/entities/underBSDLicense.docbook 8385630 
>   src/customization/sv/entities/underFDL.docbook e842f39 
>   src/customization/sv/entities/underGPL.docbook 30e31f9 
>   src/customization/sv/entities/underLGPL.docbook b0759bc 
>   src/customization/sv/entities/underX11License.docbook 4af29e2 
>   src/customization/th/entities/underArtisticLicense.docbook fa02270 
>   src/customization/th/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/th/entities/underFDL.docbook 633ce72 
>   src/customization/th/entities/underGPL.docbook a2074f3 
>   src/customization/th/entities/underLGPL.docbook 35f89bd 
>   src/customization/th/entities/underX11License.docbook 7eb81f0 
>   src/customization/tr/entities/underArtisticLicense.docbook d187604 
>   src/customization/tr/entities/underBSDLicense.docbook 685f524 
>   src/customization/tr/entities/underFDL.docbook a1ebad3 
>   src/customization/tr/entities/underGPL.docbook 74e7f95 
>   src/customization/tr/entities/underX11License.docbook 2d422e2 
>   src/customization/uk/entities/underArtisticLicense.docbook 948bfb3 
>   src/customization/uk/entities/underBSDLicense.docbook b3decb2 
>   src/customization/uk/entities/underFDL.docbook 7af44fd 
>   src/customization/uk/entities/underGPL.docbook 85246aa 
>   src/customization/uk/entities/underLGPL.docbook c2a42eb 
>   src/customization/uk/entities/underX11License.docbook afc81e0 
>   src/customization/wa/entities/underArtisticLicense.docbook fa02270 
>   src/customization/wa/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/wa/entities/underFDL.docbook 633ce72 
>   src/customization/wa/entities/underGPL.docbook a2074f3 
>   src/customization/wa/entities/underX11License.docbook 7eb81f0 
>   src/customization/xh/entities/underArtisticLicense.docbook fa02270 
>   src/customization/xh/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/xh/entities/underFDL.docbook 633ce72 
>   src/customization/xh/entities/underGPL.docbook a2074f3 
>   src/customization/xh/entities/underX11License.docbook 7eb81f0 
>   src/customization/xx/entities/underArtisticLicense.docbook fa02270 
>   src/customization/xx/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/xx/entities/underFDL.docbook 633ce72 
>   src/customization/xx/entities/underGPL.docbook a2074f3 
>   src/customization/xx/entities/underX11License.docbook 7eb81f0 
>   src/customization/zh-CN/entities/underArtisticLicense.docbook fa02270 
>   src/customization/zh-CN/entities/underBSDLicense.docbook 0dc93f1 
>   src/customization/zh-CN/entities/underFDL.docbook ad51d6e 
>   src/customization/zh-CN/entities/underGPL.docbook acd6721 
>   src/customization/zh-CN/entities/underLGPL.docbook 35f89bd 
>   src/customization/zh-CN/entities/underX11License.docbook 7eb81f0 
>   src/customization/zh-TW/entities/underArtisticLicense.docbook bc3fed6 
>   src/customization/zh-TW/entities/underBSDLicense.docbook 9893a78 
>   src/customization/zh-TW/entities/underFDL.docbook e4c1960 
>   src/customization/zh-TW/entities/underGPL.docbook 0431bcf 
>   src/customization/zh-TW/entities/underX11License.docbook 8dfc65b 
> 
> Diff: https://git.reviewboard.kde.org/r/117440/diff/
> 
> 
> Testing
> -------
> 
> Compiles; install konsole and compare the output for example for "kioclient cat help:/konsole/credits.html" -> the links to the licenses are now 
> <a ... href="help:/common/<name>-license.html"
>  instead of 
> <a ... href="common/gpl-license.html" 
> 
> You probably need to copy the common/ directory of kdoctools to <prefix>/share/doc/HTML/en/, which will be addressed in a future RR.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140409/b8609493/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list