Review Request 117437: KUser: Make guessHomeDir compatible with Windows XP

Alexander Richardson arichardson.kde at googlemail.com
Tue Apr 8 22:30:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117437/#review55244
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Richardson


On April 8, 2014, 6:16 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117437/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 6:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> SHGetKnownFolderPath was introduced in Windows Vista; change code to use GetProfilesDirectory instead. Without this change, apps using kcoreaddons don't even load in XP (whether they use KUser or not).
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt 1d17874 
>   src/lib/util/kuser_win.cpp 64702e7 
> 
> Diff: https://git.reviewboard.kde.org/r/117437/diff/
> 
> 
> Testing
> -------
> 
> Ran kusertest on Windows XP.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140408/96ccafe9/attachment.html>


More information about the Kde-frameworks-devel mailing list