Review Request 117333: Remove Solid::Networking usage from KIO

[Kevin Ottens]

> On April 7, 2014, 3:37 p.m., Kevin Ottens wrote:
> > src/ioslaves/http/http.cpp, line 1900
> > <https://git.reviewboard.kde.org/r/117333/diff/3/?file=262392#file262392line1900>
> >
> >     What about doing it? :-)
> 
> Àlex Fiestas wrote:
>     I can do that but in another review if that is ok, this is blocking the merge of apiCleanup (solid) and I would like to do that asap.

Then update ASAP. :-)

To me it looks like the right point in time to fix it and that looks like a one liner even seeing what else you wrote.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117333/#review55175
-----------------------------------------------------------


On April 2, 2014, 2:40 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117333/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Replace usage of Solid::Networking with QNetworkConfigurationManager which does everything we want.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kstatusbarofflineindicator.h 0210eb0 
>   src/filewidgets/kstatusbarofflineindicator.cpp b19e42c 
>   src/ioslaves/http/http.cpp de1a1dd 
>   src/kpac/CMakeLists.txt 97bb6b6 
>   src/kpac/config-kpac.h.cmake 440d082 
>   src/kpac/proxyscout.h 3338587 
>   src/kpac/proxyscout.cpp 9574d94 
> 
> Diff: https://git.reviewboard.kde.org/r/117333/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140408/c9f7ea8c/attachment.html>