Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

[Michael Pyne]

> On April 7, 2014, 3:24 p.m., Kevin Ottens wrote:
> > Any news?
> 
> Alexander Richardson wrote:
>     Still wondering whether I should always use getgrouplist since AFAIK no platform without it is supported (yet) or should keep the fallback code.

Flip a coin if you have too. :)

As long as the decision you make is not actually *bad* then it's better to make a poor decision now than an ideal solution 3 weeks after we ship. We hopped on the "Worse is Better" ship when we latched up to C++ after all. ;)


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116881/#review55166
-----------------------------------------------------------


On March 18, 2014, 8:14 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116881/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 8:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Fix KUser::groups() and KUser::groupNames() on UNIX
> 
> If available we use getgrouplist() which returns all group IDs.
> Otherwise we fall back to using getgrent() and checking whether gr_mem
> contains the user. For some reason gr_mem doesn't usally contain the
> users primary gid, so we add the corresponding struct group for that gid
> as well.
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt 73f28a8a3acda8449a3aee3b025e2b165722b998 
>   src/lib/util/config-getgrouplist.h.cmake PRE-CREATION 
>   src/lib/util/kuser_unix.cpp 0e0720dbb614015d6d568b39da3cab77cece76a8 
> 
> Diff: https://git.reviewboard.kde.org/r/116881/diff/
> 
> 
> Testing
> -------
> 
> Returns more groups now, should fix KUserTest::testKUser() on build.kde.org
> 
> 
> File Attachments
> ----------------
> 
>  old user->groups result (getgrent)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/18/86c5e986-8098-4c50-809c-bc3e7851447a__grouplist_getgrent_old.txt
> new user->groups result (getgrouplist)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/18/59f4ecda-5c1d-4bdc-a8ec-850de761e3a3__grouplist_getgrouplist.txt
> new user->groups result (getgrent + current gid)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/18/39d0172d-f6c8-400e-8af0-0c4aace8f7a1__grouplist_getgrent_new.txt
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140408/3ce61941/attachment.html>