Review Request 117080: cleanup KDirModelTest
Kevin Ottens
ervin at kde.org
Mon Apr 7 15:24:47 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117080/#review55167
-----------------------------------------------------------
Any news?
- Kevin Ottens
On March 26, 2014, 12:13 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117080/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 12:13 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Use Qt5 new signal slot syntax for KDirModelTest
>
> This allows removing #define connect(...) QVERIFY(QObject::connect(...)),
> since now the connections are checked at compile time.
> Also removed all disconnect calls at the end of a test, now this is done
> in cleanup() which is automatically called after each test case
>
> Always use QTestEventLoop (as is the case now already)
>
> This merely removes the #define and #ifdefs for it
>
>
> Diffs
> -----
>
> autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e
> autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c
>
> Diff: https://git.reviewboard.kde.org/r/117080/diff/
>
>
> Testing
> -------
>
> Test still passes (except for testFontUrlWithHost, but that has always timed out for me)
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140407/144b4f4d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list