Review Request 117396: syntax: enable folding new HTML5 block-level elements

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117396/#review55066
-----------------------------------------------------------

Ship it!


The patch looks good, except that the '/' characters are missing for closing the fold region.

There is room for optimization, though: Instead of using a RegExpr with \b, you could also use the rule WordDetect,
see: http://docs.kde.org/stable/en/applications/kate/kate-highlight-rules-detailled.html

But the optimization should be another review request :-)


src/syntax/data/html.xml
<https://git.reviewboard.kde.org/r/117396/#comment38407>

    Aren't you missing the '/' characters?
    
    </article
     ...


- Dominik Haumann


On April 6, 2014, 2 a.m., T.C. Hollingsworth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117396/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 2 a.m.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> enable code folding for new HTML5 elements where it makes sense
> 
> 
> Diffs
> -----
> 
>   src/syntax/data/html.xml e2c46db 
> 
> Diff: https://git.reviewboard.kde.org/r/117396/diff/
> 
> 
> Testing
> -------
> 
> the little arrow works for these elements now :-)
> 
> 
> Thanks,
> 
> T.C. Hollingsworth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140406/687b5693/attachment.html>