Review Request 117337: Fix crash in KService

David Edmundson david at davidedmundson.co.uk
Wed Apr 2 20:25:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117337/
-----------------------------------------------------------

(Updated April 2, 2014, 8:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kservice


Description
-------

Fix crash in KService

The previous code would create a shared pointer copy and copy the
internal pointer. The KServiceGroupPtr would then go out of scope and we
would use crash.

BUG: 332365


Diffs
-----

  src/services/kservicegroup.cpp 4c4d9e1 

Diff: https://git.reviewboard.kde.org/r/117337/diff/


Testing
-------

running plasmaengineexplorer --engine apps used to crash. Now it doesn't.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140402/8bcce3b6/attachment.html>


More information about the Kde-frameworks-devel mailing list