Review Request 117337: Fix crash in KService

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117337/#review54894
-----------------------------------------------------------

Ship it!


Makes sense. The whole concept of overwriting the pointer in the argument is quite dirty, but I see how it could crash without this change.


- Aleix Pol Gonzalez


On April 2, 2014, 5:33 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117337/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 5:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Fix crash in KService
> 
> The previous code would create a shared pointer copy and copy the
> internal pointer. The KServiceGroupPtr would then go out of scope and we
> would use crash.
> 
> BUG: 332365
> 
> 
> Diffs
> -----
> 
>   src/services/kservicegroup.cpp 4c4d9e1 
> 
> Diff: https://git.reviewboard.kde.org/r/117337/diff/
> 
> 
> Testing
> -------
> 
> running plasmaengineexplorer --engine apps used to crash. Now it doesn't.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140402/0c3dde0c/attachment-0001.html>