Review Request 117304: Remove clipboard data re-fetching line and its comment

[Alex Merry]

> On April 1, 2014, 4:58 p.m., David Faure wrote:
> > src/widgets/paste.cpp, line 156
> > <https://git.reviewboard.kde.org/r/117304/diff/1/?file=262229#file262229line156>
> >
> >     the event loop is here.

Ah, nested event loops, cause of so many issues :-)

As far as I can tell, the xcb platform plugin never deletes the mime data, but the windows one might when the clipboard changes.  Given that we return early in the function if the clipboard changed while the event loop was running, it should be fine, but I agree that it should be tested.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117304/#review54807
-----------------------------------------------------------


On April 1, 2014, 4:01 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117304/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 4:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Remove clipboard data re-fetching line and its comment
> 
> The comment does not appear to be true.  What is more, I cannot see when
> it was ever true, including in commit 99209e91 where it was introduced.
> 
> 
> David: can you shed any light on this?
> 
> 
> Diffs
> -----
> 
>   src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 
> 
> Diff: https://git.reviewboard.kde.org/r/117304/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/fe4bc3f5/attachment.html>