Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117299/
-----------------------------------------------------------

(Updated April 1, 2014, 4:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kio


Description
-------

Resolve a KDE4 TODO in KDesktopFileActions

Show an error message when KDesktopFileActions::run() is called with a
desktop file that looks like it's an application or runnable service,
but KService actually doesn't like it.

The comment about the error message already having been shown hasn't
been true for around 15 years, as far as I can tell (git commit
7bda6331, svn revision 20718).


Diffs
-----

  src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 

Diff: https://git.reviewboard.kde.org/r/117299/diff/


Testing
-------

Builds.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/c2e0fca4/attachment-0001.html>