Review Request 117274: Fix i18n in kross
Commit Hook
null at kde.org
Tue Apr 1 16:02:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117274/#review54796
-----------------------------------------------------------
This review has been submitted with commit b17149e7a97003d69eb221397493e54b437a3d7b by Alex Merry to branch master.
- Commit Hook
On April 1, 2014, 2:40 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117274/
> -----------------------------------------------------------
>
> (Updated April 1, 2014, 2:40 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kross
>
>
> Description
> -------
>
> Resurrect the KAboutData for the kross console
>
>
> Use i18n() instead of QCoreApplication::translate() in console app
>
> This was probably from copy-pasted command-line parsing code; everything
> else in this framework uses KI18n.
>
> Use the correct translation catalog in the console application
>
>
> Diffs
> -----
>
> src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2
> CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0
> src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef
>
> Diff: https://git.reviewboard.kde.org/r/117274/diff/
>
>
> Testing
> -------
>
> Ran kf5kross --help. Not investigated how to test the translation stuff.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/59a537c1/attachment.html>
More information about the Kde-frameworks-devel
mailing list