Review Request 117274: Fix i18n in kross

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117274/
-----------------------------------------------------------

(Updated April 1, 2014, 2:40 p.m.)


Review request for KDE Frameworks.


Summary (updated)
-----------------

Fix i18n in kross


Repository: kross


Description
-------

Resurrect the KAboutData for the kross console


Use i18n() instead of QCoreApplication::translate() in console app

This was probably from copy-pasted command-line parsing code; everything
else in this framework uses KI18n.

Use the correct translation catalog in the console application


Diffs
-----

  src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 
  CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 
  src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef 

Diff: https://git.reviewboard.kde.org/r/117274/diff/


Testing
-------

Ran kf5kross --help.  Not investigated how to test the translation stuff.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/b70048b6/attachment.html>