Review Request 117268: Deprecate the RESTORE macro
Aurélien Gâteau
agateau at kde.org
Tue Apr 1 13:50:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117268/#review54779
-----------------------------------------------------------
Ship it!
Makes sense to me. You might want to wrap it in a "#ifndef KDE_NO_DEPRECATED" check though. "Ship it" from me when wrapped.
- Aurélien Gâteau
On April 1, 2014, 1:15 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117268/
> -----------------------------------------------------------
>
> (Updated April 1, 2014, 1:15 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Deprecate the RESTORE macro
>
> RESTORE is just a non-typesafe version of kRestoreMainWindows().
>
>
> Diffs
> -----
>
> src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c
>
> Diff: https://git.reviewboard.kde.org/r/117268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/f7baa15d/attachment.html>
More information about the Kde-frameworks-devel
mailing list