Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117296/
-----------------------------------------------------------

(Updated April 1, 2014, 1:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Replacing '-' with "_" causes problem with .po files whose name contains "-". A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all "ui languages" [1] instead of just the one returned by QLocale::name().

[1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages


Diffs
-----

  modules/ECMCreateQmFromPoFiles.cmake b383311 
  modules/ECMQmLoader.cpp.in 92c0d07 

Diff: https://git.reviewboard.kde.org/r/117296/diff/


Testing
-------

Tested with kbookmarkdialogtest: translations are loaded as expected.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/0815fe55/attachment.html>