Review Request 117275: Deprecate the catalog name stuff from KAboutData

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117275/
-----------------------------------------------------------

Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne.


Repository: kcoreaddons


Description
-------

This is another thing on the "if only we'd spotted it before beta1" list.  Unfortunately, removing the second argument from the constructor is completely ambiguous for calls that do not have at least enough arguments to specify the license.


Deprecate the catalog name stuff from KAboutData

This is pretty useless - the translation catalog has to be set before
KAboutData is constructed in order to translate its arguments.


Diffs
-----

  src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 
  src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead 

Diff: https://git.reviewboard.kde.org/r/117275/diff/


Testing
-------

Builds, tests pass.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/0e428585/attachment.html>