Review Request 117273: Fix i18n in ksendbugmail
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Apr 1 01:07:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117273/#review54733
-----------------------------------------------------------
Ship it!
Good catch!
We should figure out how to figure out these problems somehow... How did you notice it?
- Aleix Pol Gonzalez
On April 1, 2014, 12:48 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117273/
> -----------------------------------------------------------
>
> (Updated April 1, 2014, 12:48 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Use i18n() instead of QCoreApplication::translate() in ksendbugmail
>
> Someone's been copy-pasting command-line parsing code; everything else
> in this framework uses KI18n.
>
> Fix ksendbugmail translation domain
>
> This is what is in Messages.sh
>
>
> Diffs
> -----
>
> src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8
>
> Diff: https://git.reviewboard.kde.org/r/117273/diff/
>
>
> Testing
> -------
>
> Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/e485aa64/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list