Review Request 112964: Prepare KPrintUtils cmake stuff

Aleix Pol Gonzalez aleixpol at kde.org
Mon Sep 30 14:01:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112964/#review41027
-----------------------------------------------------------



staging/kprintutils/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112964/#comment30118>

    Only half our modules are like this so far, should we add this as a KF5 module requirement?



staging/kprintutils/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112964/#comment30113>

    Why are you removing these?


- Aleix Pol Gonzalez


On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112964/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 9:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> ...before splitting.
> 
> 
> Diffs
> -----
> 
>   staging/kprintutils/CMakeLists.txt 28ce872 
>   staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 
> 
> Diff: http://git.reviewboard.kde.org/r/112964/diff/
> 
> 
> Testing
> -------
> 
> Still builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130930/7732cb92/attachment.html>


More information about the Kde-frameworks-devel mailing list