Review Request 112797: Bring back KStringHandler::naturalCompare()

[Mark Gaiser]

> On Sept. 30, 2013, 11:23 a.m., Aleix Pol Gonzalez wrote:
> > ping?

As before, i'm ok with it, but am not going to give another ship it :) That really is up to someone with in deep knowledge about kde4support to see if it makes sense where you placed it.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review41022
-----------------------------------------------------------


On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -----
> 
>   staging/kde4support/autotests/CMakeLists.txt 473bdba 
>   staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
>   staging/kde4support/src/CMakeLists.txt 5dc206d 
>   staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
>   staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130930/b2b3ea22/attachment.html>