Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Nicolás Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review41013
-----------------------------------------------------------


The API seems too tied to the way XKB does things. I don't think the concept of latched vs locked state would map cleanly to other platforms. What's the use case for distinguishing between them?

- Nicolás Alvarez


On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 6:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/CMakeLists.txt 3124c4d 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> -------
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130930/313a7b73/attachment.html>