Review Request 112929: Remove KPluginVerificationData

David Faure faure at kde.org
Sun Sep 29 16:50:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112929/#review41007
-----------------------------------------------------------



staging/kservice/src/plugin/kexportplugin.h
<http://git.reviewboard.kde.org/r/112929/#comment30105>

    Ah, you can probably remove this include now.


- David Faure


On Sept. 25, 2013, 11:50 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112929/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 11:50 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Remove KPluginVerificationData
> 
>     This only ever checked against major KDE version, so it's not that
>     useful. As we'll install into different subdirectories anyway, we can
>     get rid of it.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/src/plugin/kexportplugin.h 216923e 
>   staging/kservice/src/plugin/kpluginloader.cpp 91a3857 
> 
> Diff: http://git.reviewboard.kde.org/r/112929/diff/
> 
> 
> Testing
> -------
> 
> It builds, the warning is gone.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130929/e4fd308d/attachment.html>


More information about the Kde-frameworks-devel mailing list