Review Request 112880: Added KColorSchemeToken class.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41002
-----------------------------------------------------------


The name "token" surprises me a bit. Is this a usual naming scheme for accessing C++ classes from QML?
Otherwise I would think the QML code would want to just write KColorScheme.

Maybe the registration could be done in a static method, rather than letting the apps do it on their own?

The "NEED TO FIX" in the description can be removed, right?

About the branch: I see that the request is correctly for 5.0 - which means less merging trouble, so it sounds good to me :)


- David Faure


On Sept. 24, 2013, 4:08 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 4:08 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
> 
> NEED TO FIX:
> I can't include it like #include <KColorSchemeToken> at KReversi's code, only "kcolorschemetoken.h". Maybe I've missed something?
> 
> 
> Diffs
> -----
> 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130929/54bb4d10/attachment.html>