Review Request 112966: Dispatch KInterProcessWindowing to other frameworks

Aurélien Gâteau agateau at kde.org
Fri Sep 27 13:33:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112966/
-----------------------------------------------------------

Review request for KDE Frameworks, Kevin Ottens and Martin Gräßlin.


Description
-------

This review dispatches content of the KInterProcessWindowing framework to other frameworks:

- KMessageBox methods are moved to KWidgetsAddons, with a small duplication of code from KWindowSystem

- KUserTimestamp namespace is moved to KWindowSystem


Diffs
-----

  CMakeLists.txt 0939738 
  KDE5PORTING.html 57ecf2e 
  KDELibs4Config.cmake 562fa3a 
  khtml/java/CMakeLists.txt daa51ee 
  khtml/java/tests/CMakeLists.txt eaa715a 
  kioslave/http/kcookiejar/CMakeLists.txt b3985fb 
  staging/CMakeLists.txt 900bdae 
  staging/kde4support/src/CMakeLists.txt 46fce06 
  staging/kde4support/src/kdeui/kmessagebox_queued.cpp 54db324 
  staging/kinterprocesswindowing/CMakeLists.txt 3cb2127 
  staging/kinterprocesswindowing/KInterProcessWindowingConfig.cmake.in 717587c 
  staging/kinterprocesswindowing/src/CMakeLists.txt 126f9bf 
  staging/kinterprocesswindowing/src/config-kinterprocesswindowing.h.cmake 5169547 
  staging/kinterprocesswindowing/src/kmessagebox_kiw.h e53a18f 
  staging/kinterprocesswindowing/src/kmessagebox_kiw.cpp 3b63c9a 
  staging/kinterprocesswindowing/src/kusertimestamp.h 0316a15 
  staging/kinterprocesswindowing/src/kusertimestamp.cpp 38459e0 
  staging/kinterprocesswindowing/tests/CMakeLists.txt b326815 
  staging/kinterprocesswindowing/tests/kmessageboxwidtest.h 097756a 
  staging/kinterprocesswindowing/tests/kmessageboxwidtest.cpp 972e57e 
  tier1/kwidgetsaddons/src/kmessagebox.h f34c2c4 
  tier1/kwidgetsaddons/src/kmessagebox.cpp 1fff72f 
  tier1/kwidgetsaddons/tests/CMakeLists.txt 4297a3b 
  tier1/kwidgetsaddons/tests/kmessageboxwidtest.cpp PRE-CREATION 
  tier1/kwindowsystem/src/CMakeLists.txt 31fb53e 
  tier1/kwindowsystem/src/kusertimestamp.h PRE-CREATION 
  tier1/kwindowsystem/src/kusertimestamp.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112966/diff/


Testing
-------

Still builds, tests pass.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130927/293f4236/attachment.html>


More information about the Kde-frameworks-devel mailing list