Review Request 112928: Template files for frameworks

Alexander Neundorf neundorf at kde.org
Thu Sep 26 20:27:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112928/#review40893
-----------------------------------------------------------



template/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112928/#comment30044>

    The idea here was that you can simply list all required KF5 frameworks in one find_package() call:
    find_package(KF5 COMPONENTS CMake Compiler InstallDirs KCoreAddons Solid ....)
    
    When not doing this, you can also use the longer include() syntax instead of the find_package(KF5) syntax:
    include(KDECMakeSettings)
    include(KDECompilerSettings)
    include(KDEInstallDirs)
    find_package(KCoreAddons)
    


- Alexander Neundorf


On Sept. 26, 2013, 2:37 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112928/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks, Kevin Ottens, Alexander Neundorf, and Stephen Kelly.
> 
> 
> Description
> -------
> 
> This patch adds a template/ dir which contains example CMakeLists.txt and FooBarConfig.cmake.in files, based on what exists in current frameworks.
> 
> 
> Diffs
> -----
> 
>   template/CMakeLists.txt PRE-CREATION 
>   template/FooBarConfig.cmake.in PRE-CREATION 
>   template/setup.sh PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/cf655c44/attachment.html>


More information about the Kde-frameworks-devel mailing list