Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

[Valentin Rusu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112950/#review40891
-----------------------------------------------------------

Ship it!


Ship It!

- Valentin Rusu


On Sept. 26, 2013, 8:13 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112950/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 8:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Description
> -------
> 
> When calling setShortcut or setDefaultShortcut the new list of shortcuts is not added to the action(Default)Shortcuts map and so the getter methods return an empty shortcut for the given action. This can also be seen when executing the KGlobalShortcutTest::testSetShortcut() testcase against the kde4 kglobalacceld (on the CI it's just skipping this test!). With this patch the testcase succeeds.
> 
> 
> Diffs
> -----
> 
>   staging/xmlgui/src/kglobalaccel.cpp f5bcfca 
> 
> Diff: http://git.reviewboard.kde.org/r/112950/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/435c8c1a/attachment.html>