Review Request 112928: Template files for frameworks

[Aurélien Gâteau]

> On Sept. 26, 2013, 3:43 p.m., Stephen Kelly wrote:
> > > Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION?
> > 
> > Yes, that might be better. 
> > 
> > The patch looks good to me now. The above naming issue and the other re-ordering issue are up to your preferences.
> > 
> > This also marks a change in convention (removing a lot of stuff), so get Kevin to approve it for you.

OK, adding Kevin to the review. Thanks for the thorough feedback.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112928/#review40866
-----------------------------------------------------------


On Sept. 26, 2013, 4:36 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112928/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 4:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Description
> -------
> 
> This patch adds a template/ dir which contains example CMakeLists.txt and FooBarConfig.cmake.in files, based on what exists in current frameworks.
> 
> 
> Diffs
> -----
> 
>   template/CMakeLists.txt PRE-CREATION 
>   template/FooBarConfig.cmake.in PRE-CREATION 
>   template/setup.sh PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/bafc2fe4/attachment.html>