Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

[Stephen Kelly]

> On Sept. 26, 2013, 11:56 a.m., Stephen Kelly wrote:
> > You seem to be doing 3 different things here. Please make sure to do each one in a separate commit.
> 
> Vishesh Handa wrote:
>     Alright. I'll split it into 3 different commits. Do you want 3 different reviews as well? Or will this one do?

Use your own judgement to decide if each part of it needs a review request. Unless the latin1string changes are complex somehow (I haven't checked), there is no need for a pre-commit review for that.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112957/#review40856
-----------------------------------------------------------


On Sept. 26, 2013, 11:11 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112957/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 11:11 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Removed usage of KConfig for saving the size of the dialog and restoring it when the dialog is created.
> 
> Removed i18n usage from the test.
> Changed all char* strings to QLatin1String
> Changed all char to QLatin1Char
> 
> 
> Diffs
> -----
> 
>   kio/CMakeLists.txt 25dc6d9 
>   kio/kio/kmimetypechooser.h 9b5a0b7 
>   kio/kio/kmimetypechooser.cpp c68c6e5 
>   kio/tests/CMakeLists.txt 111f137 
>   kio/tests/kmimetypechoosertest_gui.cpp 5c7280e 
>   tier1/kwidgetsaddons/src/CMakeLists.txt da55c14 
>   tier1/kwidgetsaddons/src/kmimetypechooser.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/kmimetypechooser.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt a78ab21 
>   tier1/kwidgetsaddons/tests/kmimetypechoosertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112957/diff/
> 
> 
> Testing
> -------
> 
> The kmimetypechooser test works
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/1a32e462/attachment.html>