Review Request 112928: Template files for frameworks

[Aurélien Gâteau]

> On Sept. 26, 2013, 2:57 p.m., Stephen Kelly wrote:
> > template/CMakeLists.txt, line 26
> > <http://git.reviewboard.kde.org/r/112928/diff/3/?file=192775#file192775line26>
> >
> >     I've changed this signature in ecm to take a single version component instead of 3.
> >     
> >     Please create a variable beside the REQUIRED_QT_VERSION. Something like
> >     
> >      set(KF5_SELF_VERSION 5.0.0)
> >     
> >     and use it here and in the find_package calls above, and use it as @KF5_SELF_VERSION@ instead of PACKAGE_VERSION in the config file.
> >

Just updated a new version with those changes. Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION?

I was also considering grouping all includes together, so that the CMakeLists.txt has the following structure:

- find_package
- include
- ecm setup
- add subdirs
- config.cmake
- summary

Would it work?


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112928/#review40861
-----------------------------------------------------------


On Sept. 26, 2013, 3:13 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112928/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Description
> -------
> 
> This patch adds a template/ dir which contains example CMakeLists.txt and FooBarConfig.cmake.in files, based on what exists in current frameworks.
> 
> 
> Diffs
> -----
> 
>   template/CMakeLists.txt PRE-CREATION 
>   template/FooBarConfig.cmake.in PRE-CREATION 
>   template/setup.sh PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/94082319/attachment.html>