Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

Vishesh Handa me at vhanda.in
Thu Sep 26 11:11:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112957/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 11:11 a.m.)


Review request for KDE Frameworks.


Changes
-------

Use QStringLiteral instead of QLatin1String


Description
-------

Removed usage of KConfig for saving the size of the dialog and restoring it when the dialog is created.

Removed i18n usage from the test.
Changed all char* strings to QLatin1String
Changed all char to QLatin1Char


Diffs (updated)
-----

  kio/CMakeLists.txt 25dc6d9 
  kio/kio/kmimetypechooser.h 9b5a0b7 
  kio/kio/kmimetypechooser.cpp c68c6e5 
  kio/tests/CMakeLists.txt 111f137 
  kio/tests/kmimetypechoosertest_gui.cpp 5c7280e 
  tier1/kwidgetsaddons/src/CMakeLists.txt da55c14 
  tier1/kwidgetsaddons/src/kmimetypechooser.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kmimetypechooser.cpp PRE-CREATION 
  tier1/kwidgetsaddons/tests/CMakeLists.txt a78ab21 
  tier1/kwidgetsaddons/tests/kmimetypechoosertest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112957/diff/


Testing
-------

The kmimetypechooser test works


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130926/0af1bd20/attachment.html>


More information about the Kde-frameworks-devel mailing list