Review Request 112928: Template files for frameworks

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112928/#review40802
-----------------------------------------------------------


Also consider replacing FooBar with @FooBar@ or something that can be replaced by sed and adding a script which takes an arg and runs that sed command.


template/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112928/#comment29996>

    Replace kdelibs_SOURCE_DIR with the more-future-proof 
    
     "${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}"
    
    as used below.



template/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112928/#comment29994>

    If you don't use these two variables in the Config.cmake.in file, you don't need them here.



template/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112928/#comment29995>

    Should be quoted.


- Stephen Kelly


On Sept. 25, 2013, 11:39 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112928/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 11:39 a.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Description
> -------
> 
> This patch adds a template/ dir which contains example CMakeLists.txt and FooBarConfig.cmake.in files, based on what exists in current frameworks.
> 
> 
> Diffs
> -----
> 
>   template/CMakeLists.txt PRE-CREATION 
>   template/FooBarConfig.cmake.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130925/7a255e91/attachment-0001.html>