Review Request 112816: Do not use internal headers in kcolorutilsdemo

Commit Hook null at kde.org
Wed Sep 25 11:56:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112816/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 11:56 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kdelibs.


Description
-------

This is a two-commit patch:

1. Add a KColorUtils::getHcy() method

2. In kcolorutils demo: use KColorUtils::getHcy() instead of the internal KColorSpaces::KHCY

This is a required first step to make kconfigwidgets build standalone


Diffs
-----

  staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
  tier1/kguiaddons/src/lib/colors/kcolorutils.h c20c6f7 
  tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 9212bba 

Diff: http://git.reviewboard.kde.org/r/112816/diff/


Testing
-------

kcolorutilsdemo still works.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130925/2ba2708d/attachment.html>


More information about the Kde-frameworks-devel mailing list