Review Request 112926: Prepare ktextwidgets' cmake for splitting
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Sep 25 10:36:52 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112926/#review40737
-----------------------------------------------------------
Ship it!
staging/ktextwidgets/autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112926/#comment29971>
Maybe pass REQUIRED_QT_VERSION?
- Aleix Pol Gonzalez
On Sept. 25, 2013, 9:09 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112926/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 9:09 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Adds
> * find_package(Qt5 ... Test) to tests/CMakeLists.txt and autotests/CMakeLists.txt
> * find_package(Sonnet) to main CMakeLists.txt
> * if (NOT kdelibs_SOURCE_DIR) guard
>
>
> Diffs
> -----
>
> staging/ktextwidgets/CMakeLists.txt 194ca17
> staging/ktextwidgets/autotests/CMakeLists.txt 2bdfb51
> staging/ktextwidgets/tests/CMakeLists.txt 74a1e54
>
> Diff: http://git.reviewboard.kde.org/r/112926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130925/42c34d20/attachment.html>
More information about the Kde-frameworks-devel
mailing list