Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112921/#review40728
-----------------------------------------------------------

Ship it!



staging/kemoticons/src/providers/xmpp/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112921/#comment29960>

    Make it REQUIRED?
    
    find_package(Qt5Xml REQUIRED)


Looks good to me.

- Aleix Pol Gonzalez


On Sept. 24, 2013, 10:09 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112921/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 10:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Adjust CMakeLists.txt files in KEmoticons (prior to splitting)
> 
> These changes permit moving the framework without any errors.
> 
> 
> Diffs
> -----
> 
>   staging/kemoticons/autotests/CMakeLists.txt b7e890c19af2ba7febc7a45fc4a73daa25ea4f74 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be669ed1b55bc6fd5fbe036d1e38228066c 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243538e6f95db664efe0b8b162523a6b1179 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de047847ffec50ac6a68977b01809010447d 
> 
> Diff: http://git.reviewboard.kde.org/r/112921/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass. I tested moving the framework to tier3 without any compile erors.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/efa0f40b/attachment.html>