Review Request 112907: Move KEmoticons framework to tier3

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 8:44 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Description
-------

Move KEmoticons framework to tier3

Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries

TODO:
Modify API to make it more coherent


Diffs
-----

  staging/CMakeLists.txt 5c52cbe 
  staging/kemoticons/CMakeLists.txt  
  staging/kemoticons/KEmoticonsConfig.cmake.in  
  staging/kemoticons/autotests/CMakeLists.txt b7e890c 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output  
  staging/kemoticons/autotests/kemoticontest.h  
  staging/kemoticons/autotests/kemoticontest.cpp  
  staging/kemoticons/src/CMakeLists.txt  
  staging/kemoticons/src/core/CMakeLists.txt  
  staging/kemoticons/src/core/kemoticons.h  
  staging/kemoticons/src/core/kemoticons.cpp  
  staging/kemoticons/src/core/kemoticonsTheme.desktop  
  staging/kemoticons/src/core/kemoticonsprovider.h  
  staging/kemoticons/src/core/kemoticonsprovider.cpp  
  staging/kemoticons/src/core/kemoticonstheme.h  
  staging/kemoticons/src/core/kemoticonstheme.cpp  
  staging/kemoticons/src/providers/CMakeLists.txt  
  staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
  staging/kemoticons/src/providers/adium/adium_emoticons.h  
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp  
  staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop  
  staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243 
  staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop  
  staging/kemoticons/src/providers/kde/kde_emoticons.h  
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp  
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt  
  staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop  
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h  
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp  
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de0 
  staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop  
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h  
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp  
  staging/kemoticons/tests/CMakeLists.txt  
  staging/kemoticons/tests/main.cpp  
  tier3/CMakeLists.txt fb4de8f 

Diff: http://git.reviewboard.kde.org/r/112907/diff/


Testing
-------

It compiles, tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/5b594e0b/attachment-0001.html>