Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets
David Edmundson
david at davidedmundson.co.uk
Tue Sep 24 14:33:35 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112918/
-----------------------------------------------------------
(Updated Sept. 24, 2013, 2:33 p.m.)
Review request for KDE Frameworks.
Changes
-------
Edit: Stupid post-review.
Description
-------
Add index argument to KWidgetItemDelegate::createItemWidgets
This fixes a KDE5 TODO which used to pass an argument as a property
Diffs (updated)
-----
staging/kcmutils/src/kpluginselector.cpp 77cbfda5987195f15341e41c3280726e5583d87e
KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d
staging/kcmutils/src/kpluginselector_p.h 2dffae05dd87cc299ecdb05612f02dd2ad37cd2c
staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h 0e325915070006d2cfa093719d5c967f3181737d
staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp 84f9ca548068088c0bc0ff99fa460e5f7fecbccd
tier1/itemviews/src/kwidgetitemdelegate.h b874c10e9a7ab9ee9bf756ae82ce99bd64ec92d1
tier1/itemviews/src/kwidgetitemdelegatepool.cpp e9bbcad0b030c8d03fadeb6635bfa0d69d996ac9
tier1/itemviews/tests/kwidgetitemdelegatetest.cpp cfca1f9ae3df9bec1e8a570f03b5256cc935e8bb
Diff: http://git.reviewboard.kde.org/r/112918/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/75191629/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list