Review Request 112816: Do not use internal headers in kcolorutilsdemo
Kevin Ottens
ervin at kde.org
Tue Sep 24 14:19:46 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112816/
-----------------------------------------------------------
(Updated Sept. 24, 2013, 2:19 p.m.)
Review request for KDE Frameworks and kdelibs.
Changes
-------
Aimed at the frameworks branch.
Description
-------
This is a two-commit patch:
1. Add a KColorUtils::getHcy() method
2. In kcolorutils demo: use KColorUtils::getHcy() instead of the internal KColorSpaces::KHCY
This is a required first step to make kconfigwidgets build standalone
Diffs
-----
staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e
tier1/kguiaddons/src/lib/colors/kcolorutils.h c20c6f7
tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 9212bba
Diff: http://git.reviewboard.kde.org/r/112816/diff/
Testing
-------
kcolorutilsdemo still works.
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/2d058648/attachment.html>
More information about the Kde-frameworks-devel
mailing list