Review Request 112915: Fix kcrash standalone build

Aurélien Gâteau agateau at kde.org
Tue Sep 24 13:35:43 UTC 2013



> On Sept. 24, 2013, 3:32 p.m., David Edmundson wrote:
> > superbuild/CMakeLists.txt, line 46
> > <http://git.reviewboard.kde.org/r/112915/diff/1/?file=191979#file191979line46>
> >
> >     why have you removed kconfigwidgets?

Because it does not build with superbuild right now. The original intent of my patch was to fix superbuild, but I agree it does not make much sense there. Going to bring it back.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112915/#review40683
-----------------------------------------------------------


On Sept. 24, 2013, 2:19 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112915/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 2:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> - find kcrash deps in kcrash/CMakeLists.txt
> - fix kcrash dir in superbuild/CMakeLists.txt
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt 2abe36a 
>   tier2/kcrash/CMakeLists.txt 62ae2ba 
> 
> Diff: http://git.reviewboard.kde.org/r/112915/diff/
> 
> 
> Testing
> -------
> 
> Still builds
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/255956f3/attachment.html>


More information about the Kde-frameworks-devel mailing list