Review Request 112901: Remove weird cmake indirections

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 11:36 a.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

Don't specifically say we want SHARED libraries, let cmake use its defaults wisely.


Description
-------

There were some un-reviewed cmake files where libraries would be defined with a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that didn't follow through.

I propose to remove all the uses for the moment, it's not ever being set anyway.


Diffs (updated)
-----

  kdesu/CMakeLists.txt e526643 
  interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
  interfaces/kimproxy/library/CMakeLists.txt 36e55ef 
  kdewebkit/CMakeLists.txt cdc5835 
  kfile/CMakeLists.txt e05137d 
  khtml/CMakeLists.txt 4e1bb80 
  kio/CMakeLists.txt 25dc6d9 
  kio/misc/kntlm/CMakeLists.txt fe70a8d 
  kjsembed/kjsembed/CMakeLists.txt 8ed55c1 
  knewstuff/src/CMakeLists.txt c313981 
  knotify/config/CMakeLists.txt 69e1c11 
  kparts/CMakeLists.txt 6ab9391 
  kpty/CMakeLists.txt 9a79827 
  kross/core/CMakeLists.txt 52cd3d4 
  kross/qts/CMakeLists.txt 1a30bd1 
  kross/ui/CMakeLists.txt 9e7806d 
  kutils/CMakeLists.txt 0cb281d 
  staging/kde4support/CMakeLists.txt 24ee457 
  staging/kemoticons/src/core/CMakeLists.txt f7fb463 
  staging/ktextwidgets/src/CMakeLists.txt 4787c10 

Diff: http://git.reviewboard.kde.org/r/112901/diff/


Testing
-------

Everything still builds


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/d4fbdba1/attachment-0001.html>