Review Request 112902: Start cleanup for kdewebkit

[Aleix Pol Gonzalez]

> On Sept. 24, 2013, 6:58 a.m., Kevin Ottens wrote:
> > staging/kio/src/widgets/renamedialog.h, line 25
> > <http://git.reviewboard.kde.org/r/112902/diff/1/?file=191571#file191571line25>
> >
> >     How is it related to the rest of the patch?

KSqueezedTextLabel is in KWidgetsAddons which is not a public dependency of KIOWidgets, so it was not being found when building.

It's either that or make KWidgetsAddons public.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40642
-----------------------------------------------------------


On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -----
> 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   staging/kde4support/CMakeLists.txt 24ee457 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> -------
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/2575eec2/attachment.html>