Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

[Kevin Ottens]

> On Sept. 23, 2013, 10:49 a.m., Kevin Ottens wrote:
> > modules/ECMAddUnitTest.cmake, line 23
> > <http://git.reviewboard.kde.org/r/112828/diff/2/?file=190650#file190650line23>
> >
> >     I agree, it's about "automated" (vs "manual") tests here. We've no way when writing this macro to know if the user will make an automated unit test or integration test or...
> 
> Alexander Neundorf wrote:
>     As I said, in cmake, a not-automated test is not a test. I.e. in cmake a test is created via add_test(). This implies that it can be automatically executed. Anything else is not a test in cmake.
>     
>     How about ecm_add_tests()  ?
>

What would we use for the manual tests then? Just wondering since we have a similar macro copy/pasted all over the place for the manual tests. So I wouldn't be surprised if we see a patch to cover it later on.

Oh, I guess it could be ecm_add_tests vs ecm_add_manual_tests when the time comes.

So yeah I don't really mind if it's named ecm_add_tests or ecm_add_auto_tests. I'd avoid ecm_add_unit_test for the reasons I mentioned previously (it's not necessarily for unit tests).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40523
-----------------------------------------------------------


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> -------
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/e4fbd640/attachment.html>