Review Request 112907: Move KEmoticons framework to tier3
David Gil Oliva
davidgiloliva at gmail.com
Mon Sep 23 19:24:36 UTC 2013
> On Sept. 23, 2013, 6:22 p.m., Aleix Pol Gonzalez wrote:
> > Can you provide a patch with --find-copies-harder?
> >
> > It makes it much easier to read such patches where there are moves and changes.
> >
> > Also, why did you change from Qt5::Xml to Qt5Xml?
> Also, why did you change from Qt5::Xml to Qt5Xml?
It didn't compile with Qt5::Xml and Qt5::Test, so I changed them to Qt5Xml and Qt5Test...
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/#review40599
-----------------------------------------------------------
On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112907/
> -----------------------------------------------------------
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Move KEmoticons framework to tier3
>
> Done:
> -Adjust the CMakeLists.txt to the new location.
> -Substitute kde_add_plugin to add_library.
> -Substitute Qt5::Xml to Qt5Xml in target_link_libraries
> -Substitute Qt5::Test to Qt5Test in target_link_libraries
>
> TODO:
> Modify API to make it more coherent
>
>
> Diffs
> -----
>
> staging/CMakeLists.txt 5c52cbe
> staging/kemoticons/CMakeLists.txt 0e5d935
> staging/kemoticons/KEmoticonsConfig.cmake.in f394979
> staging/kemoticons/autotests/CMakeLists.txt b7e890c
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 795d3c7
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 795d3c7
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 6ddd0c7
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 6ddd0c7
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 2571b16
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 2571b16
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input f5d8887
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 0d94eb9
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 5b39691
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 5b39691
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 379e01a
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 379e01a
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input a373402
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output a373402
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 538c5b0
> staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 538c5b0
> staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input a5440d6
> staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 1f6d4aa
> staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 223ce5b
> staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 223ce5b
> staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input d685c09
> staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output e1b37c9
> staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 093690c
> staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 093690c
> staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 3994bf3
> staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output cba121a
> staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 2319ced
> staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 2319ced
> staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input d6e7e6c
> staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output d6e7e6c
> staging/kemoticons/autotests/kemoticontest.h c79c193
> staging/kemoticons/autotests/kemoticontest.cpp 083a804
> staging/kemoticons/src/CMakeLists.txt 7b10087
> staging/kemoticons/src/core/CMakeLists.txt f7fb463
> staging/kemoticons/src/core/kemoticons.h 12b8308
> staging/kemoticons/src/core/kemoticons.cpp 43dac65
> staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e
> staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef
> staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e
> staging/kemoticons/src/core/kemoticonstheme.h b8b25f7
> staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c
> staging/kemoticons/src/providers/CMakeLists.txt 445f721
> staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be
> staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267
> staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f
> staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop 181f16a
> staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243
> staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop 144ee5c
> staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b1
> staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a
> staging/kemoticons/src/providers/pidgin/CMakeLists.txt 44ac2dd
> staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop e334d3f
> staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3
> staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89ee
> staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de0
> staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop a6927e4
> staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a63
> staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed
> staging/kemoticons/tests/CMakeLists.txt f7ec91f
> staging/kemoticons/tests/main.cpp 563d760
> tier3/CMakeLists.txt fb4de8f
> tier3/kemoticons/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/KEmoticonsConfig.cmake.in PRE-CREATION
> tier3/kemoticons/autotests/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-1.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-1.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-10.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-10.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-2.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-2.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-4.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-4.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-5.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-5.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-6.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-6.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-8.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-8.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-9.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/broken-9.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-1.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-1.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-2.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-2.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-3.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-3.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-4.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-4.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-5.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-5.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-6.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-6.output PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-7.input PRE-CREATION
> tier3/kemoticons/autotests/emoticon-parser-testcases/working-7.output PRE-CREATION
> tier3/kemoticons/autotests/kemoticontest.h PRE-CREATION
> tier3/kemoticons/autotests/kemoticontest.cpp PRE-CREATION
> tier3/kemoticons/src/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/core/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/core/kemoticons.h PRE-CREATION
> tier3/kemoticons/src/core/kemoticons.cpp PRE-CREATION
> tier3/kemoticons/src/core/kemoticonsTheme.desktop PRE-CREATION
> tier3/kemoticons/src/core/kemoticonsprovider.h PRE-CREATION
> tier3/kemoticons/src/core/kemoticonsprovider.cpp PRE-CREATION
> tier3/kemoticons/src/core/kemoticonstheme.h PRE-CREATION
> tier3/kemoticons/src/core/kemoticonstheme.cpp PRE-CREATION
> tier3/kemoticons/src/providers/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/providers/adium/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/providers/adium/adium_emoticons.h PRE-CREATION
> tier3/kemoticons/src/providers/adium/adium_emoticons.cpp PRE-CREATION
> tier3/kemoticons/src/providers/adium/emoticonstheme_adium.desktop PRE-CREATION
> tier3/kemoticons/src/providers/kde/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/providers/kde/emoticonstheme_kde.desktop PRE-CREATION
> tier3/kemoticons/src/providers/kde/kde_emoticons.h PRE-CREATION
> tier3/kemoticons/src/providers/kde/kde_emoticons.cpp PRE-CREATION
> tier3/kemoticons/src/providers/pidgin/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop PRE-CREATION
> tier3/kemoticons/src/providers/pidgin/pidgin_emoticons.h PRE-CREATION
> tier3/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp PRE-CREATION
> tier3/kemoticons/src/providers/xmpp/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop PRE-CREATION
> tier3/kemoticons/src/providers/xmpp/xmpp_emoticons.h PRE-CREATION
> tier3/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp PRE-CREATION
> tier3/kemoticons/tests/CMakeLists.txt PRE-CREATION
> tier3/kemoticons/tests/main.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112907/diff/
>
>
> Testing
> -------
>
> It compiles, tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/993820e6/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list