Review Request 112829: Move XMLGUI to Tier3
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Sep 23 15:55:17 UTC 2013
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: http://paste.kde.org/p05c23fa6
> >
> > I tried to do xmlgui last week, but realized it needs more work on the underlying frameworks first (which is why I switched to kconfigwidgets)
Building standalone is not one of the things required by http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
Also it's something we probably want to deal with at a later stage, when we decide how each should be distributed.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
-----------------------------------------------------------
On Sept. 19, 2013, 4:44 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2013, 4:44 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Move xmlgui to tier3, done all the checks.
>
>
> Diffs
> -----
>
> staging/CMakeLists.txt 2a31994
> staging/xmlgui/CMakeLists.txt
> staging/xmlgui/TODO.xmlgui
> staging/xmlgui/XmlGuiConfig.cmake.in
> staging/xmlgui/autotests/CMakeLists.txt
> staging/xmlgui/autotests/kactioncategorytest.h
> staging/xmlgui/autotests/kactioncategorytest.cpp
> staging/xmlgui/autotests/kactioncollectiontest.h
> staging/xmlgui/autotests/kactioncollectiontest.cpp
> staging/xmlgui/autotests/kglobalshortcuttest.h
> staging/xmlgui/autotests/kglobalshortcuttest.cpp
> staging/xmlgui/autotests/kmainwindow_unittest.h
> staging/xmlgui/autotests/kmainwindow_unittest.cpp
> staging/xmlgui/autotests/ktoolbar_unittest.cpp
> staging/xmlgui/autotests/kxmlgui_unittest.h
> staging/xmlgui/autotests/kxmlgui_unittest.cpp
> staging/xmlgui/autotests/testguiclient.h
> staging/xmlgui/autotests/testxmlguiwindow.h
> staging/xmlgui/make_kdepackages.sh
> staging/xmlgui/make_kdepackages_updated.py
> staging/xmlgui/src/CMakeLists.txt b1d7d17
> staging/xmlgui/src/README
> staging/xmlgui/src/TODO
> staging/xmlgui/src/aboutkde.png
> staging/xmlgui/src/config-xmlgui.h.cmake
> staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake
> staging/xmlgui/src/kaboutapplicationdialog.h
> staging/xmlgui/src/kaboutapplicationdialog.cpp
> staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h
> staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp
> staging/xmlgui/src/kaboutapplicationpersonlistview_p.h
> staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp
> staging/xmlgui/src/kaboutapplicationpersonmodel_p.h
> staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp
> staging/xmlgui/src/kaboutkdedialog_p.h
> staging/xmlgui/src/kaboutkdedialog_p.cpp
> staging/xmlgui/src/kactioncategory.h
> staging/xmlgui/src/kactioncategory.cpp
> staging/xmlgui/src/kactioncollection.h
> staging/xmlgui/src/kactioncollection.cpp
> staging/xmlgui/src/kactionconflictdetector.cpp
> staging/xmlgui/src/kbugreport.h
> staging/xmlgui/src/kbugreport.cpp
> staging/xmlgui/src/kcheckaccelerators.h
> staging/xmlgui/src/kcheckaccelerators.cpp
> staging/xmlgui/src/kdepackages.h
> staging/xmlgui/src/kedittoolbar.h
> staging/xmlgui/src/kedittoolbar.cpp
> staging/xmlgui/src/kedittoolbar_p.h
> staging/xmlgui/src/kglobalaccel.h
> staging/xmlgui/src/kglobalaccel.cpp
> staging/xmlgui/src/kglobalaccel_p.h
> staging/xmlgui/src/kglobalshortcutinfo.h
> staging/xmlgui/src/kglobalshortcutinfo.cpp
> staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp
> staging/xmlgui/src/kglobalshortcutinfo_p.h
> staging/xmlgui/src/khelpclient.h
> staging/xmlgui/src/khelpclient.cpp
> staging/xmlgui/src/khelpmenu.h
> staging/xmlgui/src/khelpmenu.cpp
> staging/xmlgui/src/kkeysequencewidget.h
> staging/xmlgui/src/kkeysequencewidget.cpp
> staging/xmlgui/src/kkeysequencewidget_p.h
> staging/xmlgui/src/kmainwindow.h
> staging/xmlgui/src/kmainwindow.cpp
> staging/xmlgui/src/kmainwindow_p.h
> staging/xmlgui/src/kmainwindowiface.cpp
> staging/xmlgui/src/kmainwindowiface_p.h
> staging/xmlgui/src/kmenumenuhandler_p.h
> staging/xmlgui/src/kmenumenuhandler_p.cpp
> staging/xmlgui/src/kpartgui.dtd
> staging/xmlgui/src/kshortcuteditwidget.cpp
> staging/xmlgui/src/kshortcutschemeseditor.cpp
> staging/xmlgui/src/kshortcutschemeshelper.cpp
> staging/xmlgui/src/kshortcutschemeshelper_p.h
> staging/xmlgui/src/kshortcutsdialog.h
> staging/xmlgui/src/kshortcutsdialog.cpp
> staging/xmlgui/src/kshortcutsdialog.ui
> staging/xmlgui/src/kshortcutsdialog_p.h
> staging/xmlgui/src/kshortcutseditor.h
> staging/xmlgui/src/kshortcutseditor.cpp
> staging/xmlgui/src/kshortcutseditordelegate.cpp
> staging/xmlgui/src/kshortcutseditoritem.cpp
> staging/xmlgui/src/kshortcutwidget.h
> staging/xmlgui/src/kshortcutwidget.cpp
> staging/xmlgui/src/kshortcutwidget.ui
> staging/xmlgui/src/kswitchlanguagedialog_p.h
> staging/xmlgui/src/kswitchlanguagedialog_p.cpp
> staging/xmlgui/src/ktoggletoolbaraction.h
> staging/xmlgui/src/ktoggletoolbaraction.cpp
> staging/xmlgui/src/ktoolbar.h
> staging/xmlgui/src/ktoolbar.cpp
> staging/xmlgui/src/ktoolbarhandler.cpp
> staging/xmlgui/src/ktoolbarhandler_p.h
> staging/xmlgui/src/kundoactions.h
> staging/xmlgui/src/kundoactions.cpp
> staging/xmlgui/src/kxmlgui.xsd
> staging/xmlgui/src/kxmlguibuilder.h
> staging/xmlgui/src/kxmlguibuilder.cpp
> staging/xmlgui/src/kxmlguiclient.h
> staging/xmlgui/src/kxmlguiclient.cpp
> staging/xmlgui/src/kxmlguifactory.h
> staging/xmlgui/src/kxmlguifactory.cpp
> staging/xmlgui/src/kxmlguifactory_p.h
> staging/xmlgui/src/kxmlguifactory_p.cpp
> staging/xmlgui/src/kxmlguiversionhandler.cpp
> staging/xmlgui/src/kxmlguiversionhandler_p.h
> staging/xmlgui/src/kxmlguiwindow.h
> staging/xmlgui/src/kxmlguiwindow.cpp
> staging/xmlgui/src/org.kde.KGlobalAccel.xml
> staging/xmlgui/src/org.kde.kglobalaccel.Component.xml
> staging/xmlgui/src/thumb_frame.png
> staging/xmlgui/src/ui_standards.rc
> staging/xmlgui/tests/CMakeLists.txt
> staging/xmlgui/tests/kbugreporttest.cpp
> staging/xmlgui/tests/kmainwindowrestoretest.h
> staging/xmlgui/tests/kmainwindowrestoretest.cpp
> staging/xmlgui/tests/kmainwindowtest.h
> staging/xmlgui/tests/kmainwindowtest.cpp
> staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b
> staging/xmlgui/tests/krichtexteditor/krichtexteditor.h
> staging/xmlgui/tests/krichtexteditor/krichtexteditor.cpp
> staging/xmlgui/tests/krichtexteditor/krichtexteditorui.rc
> staging/xmlgui/tests/krichtexteditor/main.cpp
> staging/xmlgui/tests/krulertest.h
> staging/xmlgui/tests/krulertest.cpp
> staging/xmlgui/tests/ktoolbartest.cpp
> staging/xmlgui/tests/kwindowtest.h
> staging/xmlgui/tests/kwindowtest.cpp
> staging/xmlgui/tests/kwindowtest.rc
> staging/xmlgui/tests/kxmlguitest.h
> staging/xmlgui/tests/kxmlguitest.cpp
> staging/xmlgui/tests/kxmlguitest_part.rc
> staging/xmlgui/tests/kxmlguitest_shell.rc
> staging/xmlgui/tests/kxmlguiwindowtest.cpp
> staging/xmlgui/tests/kxmlguiwindowtestui.rc
> tier3/CMakeLists.txt fb4de8f
>
> Diff: http://git.reviewboard.kde.org/r/112829/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/944b289b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list