Review Request 112797: Bring back KStringHandler::naturalCompare()

Aleix Pol Gonzalez aleixpol at kde.org
Mon Sep 23 13:45:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
-----------------------------------------------------------

(Updated Sept. 23, 2013, 1:45 p.m.)


Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.


Changes
-------

Moves naturalCompare to kde4support/kdecore. The naturalCompare test goes together with it.


Description
-------

Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator.


Diffs (updated)
-----

  staging/kde4support/autotests/CMakeLists.txt 473bdba 
  staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
  staging/kde4support/src/CMakeLists.txt 5dc206d 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
  tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 

Diff: http://git.reviewboard.kde.org/r/112797/diff/


Testing
-------

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/46e8c22d/attachment.html>


More information about the Kde-frameworks-devel mailing list